Bump Black version for real#1434
Merged
ashleysommer merged 2 commits intoRDFLib:masterfrom Oct 11, 2021
Merged
Conversation
… 21.7b0 releases.
Member
|
@ashleysommer no problems: I think the plan being we peg to a single version of black for as long as we can, but that circumstances may, and here have, forced us to update. Funny lot of errors coming through the build here. Are these a result of other PRs? |
Contributor
Author
|
I don't know whats going on with those errors, they look pretty bad. I'll look into it. |
Contributor
Author
|
I think it was this #1433 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1355, #1397, #1400, #1401
I know I have stated we're sticking with Black v21.6b0 as the black version to use (and closing/reverting attempts to update it from dependbot). However this update is deliberate. There was a bug I encountered in black v21.6b0 in PySHACL, so I had to update it to a newer version. Thought I'd do the same in RDFLib, so the required version is known to be good, before we run into the same issue.